[PATCH] pstree: New applet, v2

Lauri Kasanen curaga at operamail.com
Sat Nov 6 16:59:04 UTC 2010


Hi

> +		sprintf(path, "%s/%d", PROC_BASE, pid);
> +		xstat(path, &st);
> What happens here if program with PID == pid  exits before we do xstat,
> seems to me the program run is interrupted (maybe better goto free(path)
> or  fclose(file) and ignore ? )

Upstream pstree also exits here if it can't stat, I'm not sure if 
bb should deviate.

> Hi,
> just my 0,2 cents.
>
> Ciao,
> Tito

Appreciated.

v3:

- bb_error_msg_and_die
- get_terminal_width_height
- atoi > xatoi

- Lauri


-- 
_______________________________________________
Surf the Web in a faster, safer and easier way:
Download Opera 9 at http://www.opera.com



More information about the busybox mailing list