[PATCH] unicode: fix lineedit navigation over wide and combining characters

Denys Vlasenko vda.linux at googlemail.com
Tue May 11 12:47:41 UTC 2010


On Wed, Apr 21, 2010 at 11:22 PM, Tomas Heinrich
<heinrich.tomas at gmail.com> wrote:
> Hi,
>
> this patch should make cursor movement (C-a, C-e, C-f, ...) over wide and
> combining unicode characters correct.
> It depends on the previous patch.

Please see attached.

2.patch is a part which changes how cmdedit_set_out_char works.
It renames two badly names functions, uses "clear to end of screen"
to eliminate annoying problems with clearing wide chars, and such.
Run tested. I will apply it to git. Please review.

I renamed the function to put_cur_*glyph*_and_inc_cursor, not
put_cur_*char*_and_inc_cursor, because for combining chars,
it will print _more than one_ (unicode) char.

3.patch is the remainder of your patch. Not reviewed yet.
-- 
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: application/octet-stream
Size: 7167 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20100511/649dddda/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.patch
Type: application/octet-stream
Size: 2806 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20100511/649dddda/attachment-0001.obj>


More information about the busybox mailing list