[PATCH 2/2] (g)unzip: Optimize inflate_codes()
Rob Landley
rob at landley.net
Thu Feb 11 05:04:28 UTC 2010
On Tuesday 09 February 2010 20:21:27 Rob Landley wrote:
> > I don't think this should be a config option considering the increased
> > risk of bugs with two variants. Inflate bugs can be pretty serious to
> > your data.
>
> For ~100 bytes I agree, I just wanted to make sure we'd evaluated it. It
> seems pretty reasonable, and 104 bytes is better than 209. :)
Although now that I think about it, CONFIG_FEATURE_FAST_TOP (under BusyBox
Library Tuning) claims to only save about 100 bytes...
If they're roughly equivalent, does not having a config option for this suggest
that's too granular, or does that suggest this should have a config option?
I'm so glad that's not my call anymore. :)
Rob
--
Latency is more important than throughput. It's that simple. - Linus Torvalds
More information about the busybox
mailing list