[PATCH 2/2] (g)unzip: Optimize inflate_codes()

Denys Vlasenko vda.linux at googlemail.com
Thu Feb 11 02:24:19 UTC 2010


On Wednesday 10 February 2010 08:34, Joakim Tjernlund wrote:
> > > > Left some debug in, the correct bloatcheck is:
> > > > function                                             old     new   delta
> > > > inflate_codes                                        624     791    +167
> > > > -------------------------------------------------------------------------
> > > >----- (add/remove: 0/0 grow/shrink: 1/0 up/down: 167/0)             Total:
> > > > 167 bytes text      data       bss       dec       hex   filename
> > > >  705967      2137      9072    717176     af178   busybox_old
> > > >  706134      2137      9072    717343     af21f   busybox_unstripped
> > >
> > > And yet some:
> > > function                                             old     new   delta
> > > inflate_codes                                        624     728    +104
> > > ---------------------------------------------------------------------------
> > >--- (add/remove: 0/0 grow/shrink: 1/0 up/down: 104/0)             Total: 104
> > > bytes text      data       bss       dec       hex   filename
> > >  705967      2137      9072    717176     af178   busybox_old
> > >  706071      2137      9072    717280     af1e0   busybox_unstripped

Great. But looks like you forgot to send the patch without this debug.
The only patch I found has this:

+                                       /* Align out addr */
+                                       if (e < 3)
+                                               fprintf(stderr, "error len:%d\n", e);

-- 
vda


More information about the busybox mailing list