[PATCH] modprobe: Restore "-D" option, add long options

Denys Vlasenko vda.linux at googlemail.com
Tue Dec 28 03:22:35 UTC 2010


On Monday 27 December 2010 17:04, Serj Kalichev wrote:
> From: pkun <pkun at pkunistan.(none)>

Who is pkun at pkunistan.(none) ? The real author?

> I have restored "-D" option for the several reasons:
> * The modern module-init-tools 3.12 has "-D" options and this option works. For
> example in Archlinux. The buildroot uses version 3.12, so it has this option too.
> The code from the upstream modprobe.c:
> " { "show-depends", 0, NULL, 'D' },"
> With the "-D" the busybox will be more compatible with newer module-init-tools.
> * Without short option the simple (in implementation) feature will be lost if
> the long options is disabled.
> * The "D" is better than any random symbol.
> 
> The --show-depends and -a options can be used together due to upstream modprobe
> behaviour.

Applied, thanks!

> Additionally I add long options for the other modprobe parameters. All of these
> long options are documented within modprobe's manpage. It will be more
> compatible.

Let's wait till real-world users request them.
Also, no real need to show long opts in help.

-- 
vda


More information about the busybox mailing list