Was Re: Ping - pstree + minor patch

Cathey, Jim jcathey at ciena.com
Mon Dec 6 17:07:59 UTC 2010


> > > -		} else if (*here >= ' ' && *here <= '~') {
> > > +		} else if (*here >= ' ' && *here < 0x7f) {
> > > 
> > > This makes it less readable. Why replace the char with a hex 
> > value?
> > 
> > It is less obvious that '~' is the last ASCII character.

IMHO, it is equally un-obvious that ' ' is the _first_ ASCII
character, of the printables.  If one wants to go all pedantic
on the code, isprint() might be better.  But I would probably
have left it as the original author had, as a quoted character.

-- Jim



More information about the busybox mailing list