Ping - pstree

[Denys Vlasenko]

On Sunday 05 December 2010 16:26, Lauri Kasanen wrote:
> > > I've been meaning to ask you about this. When I try to do the same,
> > > I end up usually getting a segfault. That was before any getopt 
> > > too, maybe that has an effect.
> > 
> > It should not segfault. Can you reproduce SEGV?
> 
> It's quite possible I was doing something wrong. Busybox is also the only project where I've seen argv used quite like this.

It's possible you tested argv[1] before testing argv[0].
This is unsafe: if argv[0] == NULL, then touching argv[1]
is a no-no.

> There's a typo in the width commit comment - "printer" -> "printed".

Fixed.

-- 
vda