Ping - pstree

[Lauri Kasanen]

> On Saturday 20 November 2010 13:03, Lauri Kasanen wrote:
> > Hi Denys, the list
> >
> > It's been a while, and I'm wondering if there's still something 
> > that should be fixed in the latest posted pstree patch?
> 
> Well, there is a lot to be fixed, but I am guilty too -
> was too busy with other stuff...
> 
> I committed your latest patch to git with some editing.
> Please review and run-test.
> 
> I disabled screen width detection and thread flag in struct proc:
> first one is broked and second one is unused.
> 
> --
> vda

All in all, it appears to work just fine. Comments:

> IOW: screed does overflow.

Right. I didn't test that with the -p patch, my fault.

-		} else if (*here >= ' ' && *here <= '~') {
+		} else if (*here >= ' ' && *here < 0x7f) {

This makes it less readable. Why replace the char with a hex value?

-	if (argc > 1) bb_show_usage();
-	else if (argc == 1) {
-		if (*argv[0] >= '0' && *argv[0] <= '9') {
+	if (argv[0]) {

I've been meaning to ask you about this. When I try to do the same,
I end up usually getting a segfault. That was before any getopt too, maybe that has an effect.

-	G.output_width = 132;

By removing the default, what happens if get_terminal_width_height can't 
get the real width?

> Therefore the code declares 1st thread (with smallest pid)
> to be "not-a-thread", not the thread with pid == master thread pid.
>
> Please do test your code.

I did, with that code I got output identical to PSmisc pstree.


I'll get the width detection working properly soon. Just have to say though, I really would appreciate a "it sucks donkey balls because" to complete silence...

- Lauri

-- 
_______________________________________________
Surf the Web in a faster, safer and easier way:
Download Opera 9 at http://www.opera.com