[PATCH] Improve portability
Mike Frysinger
vapier at gentoo.org
Sun Sep 6 06:34:30 UTC 2009
On Saturday 05 September 2009 15:13:56 Dan Fandrich wrote:
> --- a/archival/gzip.c
> +++ b/archival/gzip.c
> - SET_PTR_TO_GLOBALS(xzalloc(......
> + SET_PTR_TO_GLOBALS((void *)((char *)xzalloc(......
i cant see how casting a function that already returns a (void *) "improves"
anything. the opposite should be done in general -- drop useless casts.
unfortunately, it seems like Denys already merged this part.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090906/8c7b07bf/attachment.pgp>
More information about the busybox
mailing list