[patch] little fixes against Linux specific code

Mike Frysinger vapier at gentoo.org
Tue May 19 07:38:18 UTC 2009


On Tuesday 19 May 2009 02:58:24 Luca Favatella wrote:
> On 16/05/2009, Mike Frysinger <vapier at gentoo.org> wrote:
> > please write your patches against git and use git to generate the log. 
> > that way you also include your Signed-off-by tags.
> > -mike
>
> Done.
> I attach the two patches.

the comments around the IUCLC arent really useful ... it should describe why 
it's being ifdef-ed to 0, not that doing so is safe.  this method is used 
throughout busybox so the assumption is that people realize that gcc optimizes 
away such binary operations.

also, the proper comment format is Linux style, not GNU style.  thus:
/* foo */
/* foo
 * bar
 */

otherwise, things look fine to me.  unless Denys has a problem, i'll merge 
these in a bit.
-mike


More information about the busybox mailing list