Anybody want to fix ash's backspace line wrap?

[Rob Landley]

On Saturday 16 May 2009 09:17:55 Denys Vlasenko wrote:
> On Friday 15 May 2009 10:17, Rob Landley wrote:
> > By the way, what the heck is smalluint?  Why isn't uint16_t usable?  c99
> > was a full decade ago...
>
> Because bytes are more efficient on x86. On ARM, you'd rather use
> full-sized words.

*shrug*  A bit fiddly for my tastes.  (Don't command line arguments get 
promoted to a full sized words when passed on the stack or in a register?  
Doesn't your patch promote the return type to a long long, which is darn 
fiddly to generate _any_ code for on 32 bit platforms?)

> > It's an improvement, but not a full fix.  Jumping to the left edge and
> > overwriting data with a prompt is behavior other shells don't do for a
> > _reason_.
>
> Please try this patch. It prints "ESC [ 6 n" before each prompt

Sounds good in theory, but...

patching file include/libbb.h
Hunk #1 succeeded at 962 with fuzz 2.
Hunk #2 FAILED at 975.
1 out of 2 hunks FAILED -- saving rejects to file include/libbb.h.rej
patching file libbb/lineedit.c
Hunk #3 FAILED at 1440.
1 out of 3 hunks FAILED -- saving rejects to file libbb/lineedit.c.rej
patching file libbb/read_key.c
Hunk #2 succeeded at 147 (offset -1 lines).

No idea what the patch is against...

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds