[patch] define IUCLC only in platform.h

[Denys Vlasenko]

On Tue, Jul 7, 2009 at 3:05 PM, Luca Favatella<slackydeb at gmail.com> wrote:
> On 07/07/2009, walter harms <wharms at bfs.de> wrote:
> [...]
>> Luca Favatella schrieb:
>>> This patch defines IUCLC only in one place instead of "here and there".
> [...]
>> but we should give unsuspecting users a warning, should'nt we ?
>> like:
>>
>> #warn ingnoring IUCLC flag in termio
>> # define IUCLC 0
>
> Fixed in the attached second version of the patch.
> I also fixed my email address in the patch.

As I said, the patch is WRONG. platform.h may be included BEFORE
termios.h, and therefore it will see IUCLC not defined.

Version #2 is even worse: with attached .config it fails to build:

# make
  HOSTCC  applets/applet_tables
In file included from applets/../include/libbb.h:13,
                 from applets/../include/busybox.h:10,
                 from applets/applet_tables.c:16:
applets/../include/platform.h:392:3: warning: #warning "ignoring IUCLC
bit in struct termios::c_iflag"
  GEN     include/applet_tables.h
  CC      applets/applets.o
In file included from include/libbb.h:13,
                 from include/busybox.h:10,
                 from applets/applets.c:11:
include/platform.h:392:3: error: #warning "ignoring IUCLC bit in
struct termios::c_iflag"
make[1]: *** [applets/applets.o] Error 1
make: *** [applets] Error 2

--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config
Type: application/octet-stream
Size: 20811 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090707/cb2718b7/attachment-0001.obj>