bb login.c

[walter harms]

Denys Vlasenko schrieb:
> On Saturday 31 January 2009 18:37, walter harms wrote:
>> Hi Denis,
>> i have broken down my patch to login.c into several pieces (4).
>> Shall i send the diff or the .c ?
> 
> Please send diffs


attached all patches should apply on top of each other. The patches are based
on the login.c i send to the list end of last year.

v0-v1: basicly moves SELINUX and LOGIN_SCRIPTS out of the way
v1-v2: rework the get ttynam() part, move from array to pointer
v2-v3: move pswd check for PAM and !PAM into check_pswd()
	- fix getpwnam_r buffer size

Other utilities that check against the system password may use this code also.
It is the first time i venture in this area so i not know.
v3-v4: remove char *tmp

I do not claim that everything is perfect so be careful while testing.

> 
>> can i ping about ionice again again ? It is simply and 2.6 only.
> 
> Quality of code is still low.
> 
> For example, analyze what happens with variable "pid".
> It will end up uninitialized if -p is not given,
> and you will set ioprio to some random process.
> 
> Did you test "ioprio -c 1 -n 1 sleep 999"? Did you notice
> that prio is not set correctly because of the above?
> 
> I cleaned the applet up, tested and applied it to svn.
> I am asking you to test your code better.

i am bad finding my own bugs and i do not introduce them intentionally.
Unfortunately i had no testers what means you get everything that is normaly
already filtered.


re,
 wh


> --
> vda
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v0-v1.diff
Type: text/x-patch
Size: 4456 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20090201/15cf1b91/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1-v2.diff
Type: text/x-patch
Size: 1291 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20090201/15cf1b91/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-v3.diff
Type: text/x-patch
Size: 8166 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20090201/15cf1b91/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3-v4.diff
Type: text/x-patch
Size: 3411 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20090201/15cf1b91/attachment-0003.bin