mdev

[Denys Vlasenko]

On Saturday 18 April 2009 04:03, Rob Landley wrote:
> If you use it uninitialized, you get warned.  If you assign to it without 
> using the value later, it gets optimized out.  And presumably you check the 
> size with bloatcheck to figure out how much space you're using and look for 
> savings...
> 
> *shrug*  Your codebase, not mine...
> 
> > > Wrapping the whole thing in if (ENABLE_FEATURE_MDEV_RENAME) {
> > > accomplishes the same purpose without having the preprocessor chop up the
> > > code...
> > >
> > > The whole file is like this now...
> >
> > We have different coding style.
> 
> I noticed.
> 
> > I am not against your style, I just am not adopting yours as mine,
> > just like I do not expect you to adopt my style.
> >
> > Please send a patch which reduces #ifdef forest
> > along with make bloatcheck output which shows that
> > there is no code difference (apart from gcc noise of +/-10 bytes),
> > and I'll be happy to apply it.
> 
> *shrug*  I've got half an hour, sure.
> 
> Attached.

Applied, thanks. Seems to not increase code with any combination
of CONFIG_xxx.
--
vda