[PATCH] add euid egid handling to id
Denys Vlasenko
vda.linux at googlemail.com
Wed Oct 29 00:29:56 UTC 2008
On Thursday 23 October 2008 21:52, Tito wrote:
> Hi to all,
> this is a full rewrote of the id applet rather than a patch.
> My goal was to add euid egid handling to the applet without
> increasing its size.
> While at it I fixed also some differences in exit codes vs GNU id
> when an id to name translation fails,
> added some error messages when ENABLE_DESKTOP is set
> and added some clean up code when ENABLE_FEATURE_CLEAN_UP is set.
>
> The code was extensively tested with the attached script and seems to work
> correctly. The selinux code was tested in a virtualboxed fedora FC9 and seems
> to work, but the selinux people on the list may take a look at it.
> The test script maybe could be ported by some list member with better
> scripting ablities to the testsuite, the main problem probably is that it
> requires root privileges to prepare the environment for some tests.
>
> Attached you will find the test script, the patch and a drop in
> replacement to allow easier inspection of the code.
Cool! I applied a somewhat modified version. Thanks for test script,
added it too so that effort is not lost.
> PS: Denys I removed the #if HAVE_getgrouplist as it seems to me
> that now we have getgrouplist in busybox libpwd, in gnu libc and also
> in uclibc (svn?).
Let's hope newer uclibc will be released soon.
> PPS: is the G (*(struct globals*) stuff needed in this applet?
I eliminated globals.
--
vda
More information about the busybox
mailing list