mysterious segfault with busybox 1.13.0 ash

[Denys Vlasenko]

On Friday 21 November 2008 18:33, Cristian Ionescu-Idbohrn wrote:
> > > This patch should be added to fixes 1.13.0
> >
> > http://busybox.net/downloads/fixes-1.13.0/busybox-1.13.0-ash.patch
> 
>   CC      shell/ash.o
> shell/ash.c:7578: error: 'NTO2' undeclared here (not in a function)
> shell/ash.c:7578: error: array index in initializer not of integer type
> shell/ash.c:7578: error: (near initialization for 'nodesize')
> make[1]: *** [shell/ash.o] Error 1
> 
> Is this patch the correct fix?

Yes. Although I used #if/#endif, but this is not essential.
Try updated

http://busybox.net/downloads/fixes-1.13.0/busybox-1.13.0-ash.patch

> Index: shell/ash.c
> ===================================================================
> --- shell/ash.c	(revision 24115)
> +++ shell/ash.c	(working copy)
> @@ -7575,7 +7575,9 @@
>  	[NDEFUN   ] = SHELL_ALIGN(sizeof(struct narg)),
>  	[NARG     ] = SHELL_ALIGN(sizeof(struct narg)),
>  	[NTO      ] = SHELL_ALIGN(sizeof(struct nfile)),
> -	[NTO2     ] = SHELL_ALIGN(sizeof(struct nfile)),
> +	USE_ASH_BASH_COMPAT(
> +		[NTO2] = SHELL_ALIGN(sizeof(struct nfile)),
> +	)
>  	[NCLOBBER ] = SHELL_ALIGN(sizeof(struct nfile)),
>  	[NFROM    ] = SHELL_ALIGN(sizeof(struct nfile)),
>  	[NFROMTO  ] = SHELL_ALIGN(sizeof(struct nfile)),

Thanks!
--
vda