klogd broken in 1.13.0?

[Hamish Moffatt]

On Thu, Nov 20, 2008 at 12:48:50AM +0100, Denys Vlasenko wrote:
> On Thursday 20 November 2008 00:41, Hamish Moffatt wrote:
> > On Wed, Nov 19, 2008 at 08:45:53AM +0100, Denys Vlasenko wrote:
> > > Does it help if you just add this one line?
> > > 
> > >                 /* "2 -- Read from the log." */
> > >                 n = klogctl(2, log_buffer + used, KLOGD_LOGBUF_SIZE-1 - used);
> > >                 if (n < 0) {
> > >                         if (errno == EINTR)
> > >                                 continue;
> > >                         syslog(LOG_ERR, "klogd: error %d in klogctl(2): %m",
> > >                                         errno);
> > >                         break;
> > >                 }
> > > +               log_buffer[used + n] = '\0';
> > 
> > Yes that works.
> 
> Minimal fix is here:
> 
> http://busybox.net/downloads/fixes-1.13.0/busybox-1.13.0-klogd.patch

It's working.

> and svn has a bit bigger fix (or shall I say "smaller" -
> code has shrank) is in svn.
> 
> Can you test svn version?

That works too.

thanks,
Hamish
-- 
Hamish Moffatt VK3SB <hamish at debian.org> <hamish at cloud.net.au>