[patch] setfiles bugfix

Denys Vlasenko vda.linux at googlemail.com
Wed Sep 26 17:59:15 UTC 2007


On Wednesday 26 September 2007 08:44, Yuichi Nakamura wrote:
> 
> This patch fixes bug in setfiles.
> setfiles segfaults in p[0] = '\0'.

I am applying this instead:

diff -urN busybox-1.7.1/selinux/setfiles.c busybox-1.7.1-setfiles/selinux/setfiles.c
--- busybox-1.7.1/selinux/setfiles.c    2007-09-03 12:48:46.000000000 +0100
+++ busybox-1.7.1-setfiles/selinux/setfiles.c   2007-09-26 18:58:22.000000000 +0100
@@ -189,7 +189,7 @@
                        file_sep = strrchr(tmp_path, '/');
                        if (file_sep == tmp_path) {
                                file_sep++;
-                               p[0] = '\0';
+                               path[0] = '\0';
                                p = path;
                        } else if (file_sep) {
                                *file_sep++ = '\0';
 

It should be shorter.
--
vda



More information about the busybox mailing list