[PATCH] more devfsd clean up and size reduction

Tito farmatito at tiscali.it
Sat Jun 30 12:16:33 UTC 2007


Hi,
as nobody complained about my previous devfsd patch
(....i presume because nobody is using it ;-) )
here is one more round
of size reduction and code clean style clean up.
This patch removes the functions
msg_logger, msg_logger_and_die, fork_and_execute
and uses libbb stuff instead.

Bloat-o-meter says:

root at localhost:~/Desktop/busybox# scripts/bloat-o-meter busybox_old busybox_unstripped
function                                             old     new   delta
expand_variable                                      756     759      +3
get_variable                                         259     257      -2
get_uid_gid                                          122     120      -2
do_ioctl_and_die                                      27      25      -2
st_expr_expand                                       488     485      -3
signal_handler                                        94      91      -3
devfsd_main                                          842     833      -9
service_name                                        2444    2433     -11
read_config_file                                    1119    1098     -21
msg_logger_and_die                                    31       -     -31
.rodata                                           125143  125111     -32
msg_logger                                            88       -     -88
fork_and_execute                                      95       -     -95
------------------------------------------------------------------------------
(add/remove: 0/3 grow/shrink: 1/9 up/down: 3/-299)           Total: -296 bytes

BE WARNED THAT THIS IS ONLY COMPILE TESTED!!!

If there are some volunteers for testing it .....

Denis could you please take a look at my use
of spawn, xspawn, wait4pid and bb_daemonize_or_rexec
as I never used them before and i'm not quite sure 
if i've done things right.............
and apply the patch if you like it.

Ciao,
Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: devfsd03.patch
Type: text/x-diff
Size: 11789 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20070630/1a433e99/attachment-0002.bin 


More information about the busybox mailing list