[PATCH] mini port scanner for busybox - V2

Denis Vlasenko vda.linux at googlemail.com
Thu Jun 14 19:00:41 UTC 2007


On Thursday 14 June 2007 16:41, Luciano Rocha wrote:
> On Thu, Jun 14, 2007 at 04:12:20PM +0200, Tito wrote:
> > +static int my_gettimeofday(void)
> > +{
> > +	struct timeval now;
> > +	
> > +	if (gettimeofday(&now, NULL))
> > +		return 0;
> > +	return (now.tv_sec * 1000000 + now.tv_usec);
> 
> Err, this overflows in current 32bits systems. tv_sec is already in the
> 31 bit limit (1181831862).
> 
> Use long long instead.

But he uses these only for time diff (t2 - t1 style thing).
It's ok then.

Actually, my_gettimeofday looks like possible libbb addition.
traceroute can use it already.

The only problem is that gettimeofday will jump if time
is reset. But it's not a new problem.
--
vda



More information about the busybox mailing list