PATCH: replacing exec*p with BB_EXEC*P

Denis Vlasenko vda.linux at googlemail.com
Tue Feb 6 00:58:21 UTC 2007


On Monday 05 February 2007 14:13, Gabriel L. Somlo wrote:
> On Mon, Feb 05, 2007 at 09:49:00AM +0100, Bernhard Fischer wrote:
> > On Mon, Feb 05, 2007 at 07:20:54AM +0100, Tito wrote:
> > >On Monday 05 February 2007 00:23, Gabriel L. Somlo wrote:
> > >> +       BB_EXECVP(*argv, argv);
> > >>         bb_perror_msg_and_die("cannot execute %s", *argv);
> > >
> > >Hi,
> > >shouldn't the    bb_perror_msg_and_die("cannot execute %s", *argv)
> > >be moved inside  BB_EXECVP(*argv, argv); ?
> > >This would probably save some space.
> > 
> > seconded :)
> 
> I too noticed that a lot of the code surrounding execvp/BB_EXECVP
> looks similar in a lot of the places it happens. However, BB_EXECVP
> was meant as strictly a drop-in replacement for the execvp function
> call.

I prefer it to stay that way. Dying variety should be called
xexecvp() according to our usual conventions.
--
vda



More information about the busybox mailing list