[PATCH] awk.c: str[n]casecmp requires strings.h

Rich Felker dalias at aerifal.cx
Fri May 26 19:32:19 UTC 2006


On Fri, May 26, 2006 at 10:50:13AM -0400, Rob Landley wrote:
> On Thursday 18 May 2006 9:02 pm, Rich Felker wrote:
> > portability/gnuism cleanup, no comment.
> >
> > rich
> 
> Could we add this header to libbb.h or platform.h instead, with a comment that 
> on linux systems string.h covers strings.h too but on macosx it doesn't?  I 
> realize bernhard already checked it in, but I'd prefer a global solution.

MacOSX? All of my fixes are based on my own libc implementation which
is implemented directly from reading POSIX/SUSv3/ISO C rather than
relying on traditional implementations as a guide. These same issues
may apply on OSX but that's not how I found them.

> Playing whack-a-mole with every app that needs this when it works just fine 
> without it on Linux (so we won't notice if we break it again) doesn't give me 
> a warm fuzzy feeling about maintainability.
> 
> I also dislike header tweak patches on general principles.  I prefer the "one 
> big header that includes the common standard headers" approach, which makes 
> ccache happier.

Whatever you like is ok with me. I'm just the user not the developer
and as long as it works and it's not bloated and doesn't require me to
use a bloated OS/libc/tools I'm happy. :)

> That said, I just haven't got it in me to care that much about header files.  
> My preferences run towards arranging things so I can pay even less attention 
> to them. :)

:)

Rich




More information about the busybox mailing list