[PATCH] CFLAGS_EXTRA and quotes

[Lucas C. Villa Real]

On 5/18/06, Rob Landley <rob at landley.net> wrote:
> On Wednesday 17 May 2006 3:01 pm, Lucas C. Villa Real wrote:
> > Is there a reason to remove double quotes (") from CFLAGS_EXTRA? That
> > breaks the usage of flags such as "-DFOODIR=\"/path/to/foo\"".
> >
> > I'm asking that because of a patch I'm going to submit to make
> > "/lib/modules" configurable at modprobe.c, given that one can already
> > specify a different MODDIR at the kernel's Makefile.
>
> Not a clue, sorry.  It was added in
> http://busybox.net/downloads/patches/svn-6102.patch but I dunno why.

I've asked Erik in a private email about that commit, and I was told
that the quotes removal is being done so that this kind of error
doesn't happen:
  gcc "-Wall -ggdb3 -O2 -Werror" foo.c -o foo.o

I'll workaround my patches here so that they don't rely on
CFLAGS_EXTRA, as the quotes removal seems sane.

Thanks,

-- 
Lucas
powered by /dev/dsp