proposal to start merging some source files in libbb/
Robert P. J. Day
rpjday at mindspring.com
Thu May 18 17:31:01 UTC 2006
On Thu, 18 May 2006, Paul Fox wrote:
> > months back. it seems that there's just too many trivial source files
> > in libbb/, and some of them could be merged and be even more
> > meaningful afterwards.
> >
> > as a trivial example,
> >
> > create_icmp_socket.c
> > create_icmp6_socket.c
> >
> > those files each define a single function, and have common includes,
>
> is it not it true that one can build a busybox that only needs one
> of these? if so, won't combining them in a single .o cause them
> both to be pulled in all the time?
BTW, my longer-term thought is to do a fair bit more merging to
collect related functions into the same single source file. i can
imagine something like
libbb/string_ops.c
trim()
chomp()
last_char_is()
bb_skip_whitespace()
and so on. at the moment, each of those functions sucks up its own
source file, for no obvious reason.
rday
More information about the busybox
mailing list