[PATCH] remove shm* from hdparm

[Bernhard Fischer]

On Thu, May 18, 2006 at 02:40:13PM +0200, Tito wrote:
>On Wednesday 17 May 2006 06:00, you wrote:
>> On Tuesday 16 May 2006 4:23 pm, Tito wrote:

>> > BTW: make bloatcheck returns this error
>> >  make bloatcheck
>> > make[1]: *** No rule to make target `busybox_old', needed by `bloatcheck'. 
>> > Stop. make: *** [bloatcheck] Error 2
>> >
>> > Maybe I'm too stupid to use it ?!?
>> 
>> Nah, it needs documentation.
>> 
>> It compares busybox_old with busybox_unstripped.  So you need to make the old 
>> version, mv busybox_unstripped busybox_old, then make the new version, then 
>> make bloatcheck.
>> 
>> It doesn't create busybox_old.  You have to supply that.  It'll create 
>> busybox_unstripped if necessary...
> Couldn't this be automated by the script
>
> cp busybox_unstripped busybox_old
>

.PHONY: reference
reference: busybox_unstripped
	$(Q) cp $< busybox_old

Otherwise you risk overwriting your reference binary..

Of course bloatcheck should not read
bloatcheck: busybox_old busybox_unstripped
        @$(top_srcdir)/scripts/bloat-o-meter busybox_old busybox_unstripped

like it currently does, but rather

bloatcheck: busybox_old busybox_unstripped
        $(Q)if [ -r busybox_old ] ; then \
		$(top_srcdir)/scripts/bloat-o-meter \
			busybox_old busybox_unstripped ; \
	else \
		echo "Warning: no reference found!" ; \
		echo "Run $(MAKE) reference on the vanilla source first" ; \
	fi

(modulo possible typos).