[patch] sed replace bb_get_chunk_from_file

Rob Landley rob at landley.net
Wed May 17 20:18:33 UTC 2006


On Wednesday 17 May 2006 4:07 am, walter harms wrote:
> hi list,
> this patch replaces bb_get_chunk_from_file() with getline() that is part
> of glibc. I did some simple tests and found no problems.
>
> btw: i run sed.tests but i am not sure that it realy tested the patched
> version.

ln -s ../busybox sed
PATH=.:$PATH ./sed.tests

And the reason I have these in the todo heap is that I've got half a rewrite 
of sed to make it _properly_ handle embedded nul bytes (which requires 
changing the entire codepath to take buffer+length rather than a nul 
terminated buffer.)

If you'd like to poke at me and say "prioritize that", I can. :)

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list