[patch] sed replace bb_get_chunk_from_file
walter harms
wharms at bfs.de
Wed May 17 16:20:33 UTC 2006
Rich Felker wrote:
> On Wed, May 17, 2006 at 10:07:42AM +0200, walter harms wrote:
>> hi list,
>> this patch replaces bb_get_chunk_from_file() with getline() that is part
>> of glibc. I did some simple tests and found no problems.
>
> It's part of glibc!! Not standard. Please make this conditional on a
> configured option. Also see the patch I sent a while back that fixes
> the massive slowness in this function by using fgets, which is
> portable.
>
The pont of use getline() is that it can handle any line lenght.
fgets() needs an already allocated buffer.
or are your talking about bb_get_chunk_from_file() ?
I agree that getline() is GNU only, it would be helpfull if we can agree
that we use gnu extension and provide an replacement that can be linked
anytime if such beast is missing.
re,
wh
More information about the busybox
mailing list