Busy Box [bug -fix]

[Rob Landley]

On Tuesday 16 May 2006 4:11 am, Patrick S wrote:
> Hi, Developers,
>
> Busybox is a great piece of software I have every seen!.
>
> I recently use buildroot to build embedded linux, during the process, it
> gives me the following errors:
>
> ------------------------------------------------------
> [sp at spf-pc5-linux busybox]$make
>       ....
>      LINK busybox_unstripped
> /home/sp/buildroot/build_arm/busybox/libbusybox.so: undefined reference to
> `llist_free_one'
> collect2: ld returned 1 exit status
> make[1]: *** [busybox_unstripped] error 1
> make: *** [_all] error 2
> ------------------------------------------------------
>
> I found the helper function has some incorrectness:  libbb/list.c
>
> the #ifdef is for every single function, which is fine, however,
> L_llst_freerequires the
> L_llist_free_one to be defined as well.
> What I did was to move the function llist_free_one into the bracket defined
> by #ifdef L_llist_free, and remove the block #ifdef L_llist_free_one

Sounds like you got a snapshot that had half a patch checked in.  (Probably my 
fault, since I made that change.)  llist_free_one was renamed to llist_pop 
(it's functionality also changed: it returns the object whose list structure 
it freed instead of just discarding it.  We're slowly cleaning up our memory 
allocation so that leaking stuff for exit() to free for us is a config option 
rather than a requirement.)

If you've never played with busybox before, I'd recommend sticking with the 
release versions.  (Is 1.1.2 available in buildroot?  That's only about a 
month old.  The buildroot mailing list is at uclibc at uclibc.org, they'd be the 
people to ask...)

Rob
-- 
Never bet against the cheap plastic solution.