[PATCH] replace findstring with filter

Bernhard Fischer rep.nop at aon.at
Mon May 15 09:03:16 UTC 2006


On Fri, May 12, 2006 at 04:47:35PM -0400, Rob Landley wrote:
>On Friday 12 May 2006 8:39 am, Robert P. J. Day wrote:
>>   technically, filter is safer here since it matches based on entire
>> words whereas findstring might match substrings (unlikely to actually
>> cause a problem but why live dangerously?)
>>
>> rday
>
>I'll leave this one up to Bernhard...

Well, it's extremely unlikely to run into matching the wrong stuff,
since we match against the *full path* including the extension of
the file, as you note.

While your change would be technically correct (I'm not really opposed
to it, i honestly think that it makes no difference whatsoever since we
are unlikely to introduce source with this.c.that this.c.there etc), it
is incomplete.
If you provide a patch which adjusts these in the whole tree (not just
in libbb), then it's ok to be checked in.




More information about the busybox mailing list