[patch] crond misc

Bernhard Fischer rep.nop at aon.at
Wed May 10 17:10:58 UTC 2006


On Wed, May 10, 2006 at 01:06:20PM -0400, Rob Landley wrote:
>On Wednesday 26 April 2006 3:53 pm, Bernhard Fischer wrote:
>> On Wed, Apr 26, 2006 at 09:42:10PM +0200, Bernhard Fischer wrote:
>> >Hi,
>> >
>> >Compile-tested only.
>> >OK?
>> >
>> >PS: doesn't do away with the warning, perhaps i'll look into this
>> >later..
>>
>> Scratch that. Off by one ;)
>>
>> Sorry.
>
>When you say scratch that, do you mean it doesn't fix the warning or it 
>shouldn't be applied?

It shouldn't be applied (it's wrong. IIRC it needs to be on the
prototype, which didn't work without touching the APPLET defines. My
memory is a bit vague on that, though).
>
>Looking at crond.c, I notice that it's got lots of #ifdefs for 
>FEATURE_DEBUG_OPT, which can never be set by our config system.  Any idea 
>what that's for?  (It should either be added to the config system or removed 
>entirely.  I can't clean it up to use ENABLE and USE macros unless it's in 
>the config system...)

This should be a CONFIG_FEATURE_CROND_DEBUG, yes.



More information about the busybox mailing list