[PATCH] hdparm new option parsing

Tito farmatito at tiscali.it
Mon May 8 06:33:02 UTC 2006


On Monday 8 May 2006 01:46, Rob Landley wrote:
> On Sunday 07 May 2006 3:28 pm, Tito wrote:
> > > Which has the advantage that the knowledge is localized (the use site is
> > > where the decision whether or not to include the functionality is
> > > expressed), but without the line-based preprocessor syntax.  It works
> > > well with automatic string concatenation as well.  I.E. "thing" "also"
> > > becomes "thingalso", thus you can do "thing" USE_ALSO("also")
> >
> > New version of the previous patch with the ENABLE_ and USE_ stuff.
> > Enjoy.
> 
> Looking further at your patch: what does noisy do?
> 
> It seems to be !quiet, so why have two variables?  Also, you have a comment 
> that says you're initializing get to 0 in parse_opts, yet noisy is 
> initialized to 1 when it's declared...

 -q     Handle  the  __next__ flag quietly (noisy = 0, get_* = noisy,  noisy = 1), suppressing normal output.  This
              is useful for reducing screen clutter when running  from  system
              startup  scripts.   Not  applicable  to the -i or -v or -t or -T
              flags.

Ciao,
Tito
> Could you explain this logic to me?
> 
> Rob



More information about the busybox mailing list