[PATCH] hdparm new option parsing

[Rob Landley]

On Sunday 07 May 2006 3:28 pm, Tito wrote:
> > Which has the advantage that the knowledge is localized (the use site is
> > where the decision whether or not to include the functionality is
> > expressed), but without the line-based preprocessor syntax.  It works
> > well with automatic string concatenation as well.  I.E. "thing" "also"
> > becomes "thingalso", thus you can do "thing" USE_ALSO("also")
>
> New version of the previous patch with the ENABLE_ and USE_ stuff.
> Enjoy.

Looking further at your patch: what does noisy do?

It seems to be !quiet, so why have two variables?  Also, you have a comment 
that says you're initializing get to 0 in parse_opts, yet noisy is 
initialized to 1 when it's declared...

Could you explain this logic to me?

Rob
-- 
Never bet against the cheap plastic solution.