[PATCH] Re: glitch with strlen [was: Re: Shells in 1.1.2]

[Rob Landley]

On Friday 05 May 2006 5:09 pm, Bernhard Fischer wrote:

> >Immense churn to work around a gcc bug, which presumably doesn't even
> > affect non-gcc compilers.  No.
> >
> >If you want to lobby the gcc folks to make -fno-builtin-strlen actually
> >_work_, feel free.
>
> try
> void foo(void){strlen("string");}
> with and without -fno-builtin-strlen.
>
> What is it that is not working? Please explain.

The last time I tried it, it wasn't working, but that may have been on gcc 
3.x.

If -fno-builtin-strlen gives us the same general result as bb_strlen on gcc 
4.x, then the obvious thing to do is add a check_gcc for that and yank 
bb_strlen entirely.  It's a small enough optimization that gcc 3.x can live 
without it.

Rob
-- 
Never bet against the cheap plastic solution.