[PATCH] ls: clean up memory leak
Vladimir N. Oleynik
dzo at simtreas.ru
Wed May 3 07:11:54 UTC 2006
Rob Landley wrote:
>>Sorry, Rob. This patch was a conglomeration of a patch by Vladimir N.
>>Oleynik <dzo at simtreas.ru> and a patch from myself. I'll clean up the
>>patch and remove Vladimir's UTF-8 work and resubmit it.
> If it's from Vladimir I'd like to confirm that it's under the GPL, since he's
> explicitly stated that some of his previous patches were not GPL.
10-th time:
My licensed is more free as GPL, but if not like my works, you do not use.
I do not see conflict it with GPL.
As result: good patch for the "ls" applet you reject as your the bad maintain
political but not license a problem.
> And I'm not against UTF-8 support, I'd just like it to be done cleanly, and
> the CONFIG option would need to go in before stuff using that CONFIG option.
Its is for dispute a concept patch, do not for apply. Any libc and busybox
have not XXXstrlen with return width of utf8 string: mblen return error if
found problem from string. Its not usable, for example "top" applet used
kernel's stored buffer striped width 14 chars without know as multibute, and
end result is: last multibute may be not complete.
See the #ifdef CONFIG_FEATURE_UTF8_SUPPORT section from
ftp://ftp.simtreas.ru/pub/my/bb/bb_different/top.c.gz
--w
vodz
More information about the busybox
mailing list