get_header_tar.c: makedev [PATCH]

Rob Landley rob at landley.net
Thu Sep 29 00:23:41 UTC 2005


On Wednesday 28 September 2005 17:14, Shaun Jackman wrote:
> get_header_tar.c uses the macro makedev, which is not defined by any
> standard header. In practice, it's defined either by sys/types.h,
> sys/sysmacros.h, or sys/mkdev.h. glibc defines makedev in
> sys/sysmacros.h which is included by sys/types.h. To support newlib,
> include sys/sysmacros.h directly. I armoured the include in an ifdef
> to allow for a system that defines makedev in sys/types.h but does not
> provide sys/sysmacros.h.

If sys/sysmacros.h is the correct #include then we should include it 
unconditionally.  (If uClibc needs to be fixed, we can fix it.)

If sys/types.h is the correct #include, then fix newlib.

How do we go about determining this?

Rob



More information about the busybox mailing list