[patch] make new parts of testsuite work via make check

[Rob Landley]

On Tuesday 20 September 2005 02:36, Bernhard Fischer wrote:

> or directly:
> someone at here:/scratch/obj/busybox/testsuite# ./runtest 2>&1 >&1 | egrep
> -v "(PASS|FAIL)"
> ln: creating symbolic link `links/busybox' to `../../busybox': No such
> file or directory

Hmmm...  perchance is it assuming the "links" directory is there, when it 
isn't?  (Looks like my attempt to add an empty directory to svn failed, and 
rather than fiddle with it I'll just add a mkdir call to runtest...)

Ok, fixed.

> >Looking at the patch...
> >
> >Okay, I'd really rather _not_ introduce unnecessary environmental
> > dependencies on running these tests.  When it's run outside of make,
> > $srcdir is not set.
>
> Hm? My copy of trunks runtest reads:
> $ grep srcdir= runtest
> [ -n "$srcdir" ] || srcdir=$(pwd)

Yeah, but if you run the test directly then srcdir has not been set.

> >We should not depend on srcdir being set.  I'd prefer making the
> > dependency on the current directory containing testing.sh more explicit,
> > and having make do a cd before trying to run it.
> >
> >It's _nice_ to be able to just run "COMMAND=../busybox ./busybox.tests".
>
> I thought one is supposed to make check rather than executing every
> single one of *.tests by hand, no?

The thing is you can run ./busybox.tests directly, and right now it works.  
(If you don't feed it COMMAND= it'll look for busybox in the $PATH.)  Your 
patch breaks that.

Rob