[patch] size reduction of grep

Rob Landley rob at landley.net
Tue Sep 20 00:20:59 UTC 2005


On Sunday 18 September 2005 17:22, Bernhard Fischer wrote:
> Hi,
>
> $ size findutils/grep.o*
>    text    data     bss     dec     hex filename
>    1545       0      40    1585     631 findutils/grep.o
>    1697       0      40    1737     6c9 findutils/grep.o.oorig
>
>
> tested with make check.
> PS: Rob, i'm aware that you don't like such defines, but the patch would
> have been considerably bigger otherwise. Is that acceptable?

I'm not against _sane_ use of the preprocessor, and this looks sane.  However 
it is traditional for #defines to be UPPER_CASE to make them easier to spot.

I am not, however, going to check this in until I hear from Erik about whether 
or not he wants to give you an svn login of your very own to love and hug and 
squeeze and call george.

Hey Erik!

(Hey Cool-aid!  Go get Erik!  For the non-english speakers in our audience, or 
anyone under the age of 20: don't worry about it.  If you really must know, I 
just invoked a metaphorical anthropormorphic punch bowl and asked it to 
deliver a message, at the expense of some property damage.  I said don't 
worry about it.  It didn't make sense in the commercials either...)

> Bernhard

Rob



More information about the busybox mailing list