less bug?

Rob Landley rob at landley.net
Tue Sep 20 00:13:16 UTC 2005


On Sunday 18 September 2005 10:24, Tito wrote:
> On Sunday 18 September 2005 16:20, you wrote:
> > On Sunday 18 September 2005 05:57, Tito wrote:
> > > This changeto  data_readlines() fixes it for me.
> > > This seems to work with files and with pipes,
> > > but should be tested by the mantainer and the gurus.
> > > Let me know if you need a diff.
> >
> > If it isn't a diff I can't easily tell what changed, and it's noticeably
> > more work to apply (cut and paste on kde turns tabs into spaces).
> >
> > Rob
>
> Here is the diff.
>
> Ciao,
> Tito

!feof(fp) is actually better than feof(fp)==0 because the ! version logically 
translates to "not end of file on fp".  That's exactly what ! is for.  Why 
change it?

Otherwise seems sane.  (I was offline for a couple days, and it looks like 
vodz got it while I was out...)

Rob



More information about the busybox mailing list