[VODZ] mke2fs

Tito farmatito at tiscali.it
Mon Sep 19 20:26:55 UTC 2005


Hi, vodz 
in your last changes in mke2fs.c at line 797-803

	/* Update our PATH to include /sbin  */
	if (oldpath) {
		char *newpath;

		bb_xasprintf(&newpath, "%s:%s", PATH_SET, oldpath);
	} else
		putenv (PATH_SET);

shouldn't this be:
	/* Update our PATH to include /sbin  */
	if (oldpath) {
		char *newpath;

		bb_xasprintf(&newpath, "%s:%s", PATH_SET, oldpath);
                putenv (newpath);
                if (ENABLE_FEATURE_CLEAN_UP) free(newpath);
	} else
		putenv (PATH_SET);

as newpath is not used elsewhere.

Ciao,
Tito



More information about the busybox mailing list