[PATCH] size reduction and clean up swaponoff.c

[Bernhard Fischer]

On Sat, Sep 17, 2005 at 02:11:45PM -0500, Rob Landley wrote:
>On Saturday 17 September 2005 12:46, Bernhard Fischer wrote:
>> >We need to work out some kind of mechanism for this, but having an
>> >individual .c file and individual .o file for each string is just...  Ick.
>>
>> We do *not* have individual .c files for them. In another thread i
>> proposed to put them into messages.c but you objected ¹). I locally have
>> them now in libbb/static_strings.c but any suggestion for a more
>> appropriate name or place is welcome. It's really a minor detail, imho,
>> but i want to resolve it sooner rather than later.
>
>I have no objection to the name static_strings.c, I'm just trying to visualize 
>the build process.  I don't think I quite understand what you're doing here.  

libbb.h has a comment to move CURRENT_TTY and CONSOLE_DEV into .o files
(in libbb). I'm doing this as descibed in this mail
http://busybox.net/lists/busybox/2005-September/016050.html
This is the same way as e.g. xfuncs.c works, or the patch i just sent
which consolidates the pwd helpers into a single .c file.

>(These strings wind up in libbb.a, right?  I take it the individual .o files 
>are some kind of hack so they can be individually linked in without sucking 
>in the others...?)

That's exactly what is happening, yes.
>
>This static_strings file is probably going to want to eat libbb/mtab_file.c, 
>by the way.

Ok. Just tell me if you would apply such a patch and let me know if you
prefer  any other name  for the .c file.

cheers,
Bernhard