The less patch is in.
Rob Landley
rob at landley.net
Sat Sep 17 16:54:27 UTC 2005
On Saturday 17 September 2005 10:07, Rob Sullivan wrote:
> Sorry about the error in my patch - I thought I'd put less in the
> right place in terms of alphabetical order, somehow.
> I'd be happy to write the Perl script, if as recompense for my patch
> if nothing else. I'll probably be able to submit it together with the
> cleanup patch, as neither appears to be too complex.
>
> Rob
Your patch didn't _break_ anything, it's just the binary search to find the
applet name couldn't find an out-of-order entry, so we couldn't trigger it.
As others have said: no perl in the build process, please. Sed would work but
I'd like to point out that in the past two years this is the first time I
remember seeing this problem, so it's not exactly a high priority. (This is
something that a testsuite that attempts to exercise the applet would also
catch.)
I await your cleanup patch, or I could start working on it if you like.
(There's lots of opportunities to shrink the code, but you're the maintainer
of this applet...)
Rob
More information about the busybox
mailing list