[PATCH] size reduction and clean up swaponoff.c
Rob Landley
rob at landley.net
Sat Sep 17 11:50:03 UTC 2005
On Saturday 17 September 2005 05:19, Bernhard Fischer wrote:
> On Fri, Sep 16, 2005 at 12:50:49AM -0400, Mike Frysinger wrote:
> >On Wednesday 14 September 2005 11:12 am, Rob Landley wrote:
> >> On Monday 12 September 2005 21:26, Mike Frysinger wrote:
> >> > unrelated to this patch, and minor overall, but our swap utils
> >> > different
> >
> >if they really care they could just pipe into /dev/null
>
> I put CURRENT_TTY and CONSOLE_DEV into their own obj files.
Ouch.
> Should we put DEV_NULL also in it's obj file contained in libbb?
/dev/null, /dev/tty, and /dev/console are all constant strings, right? Living
at standard defined places?
If you're saying we should have one instance of these strings to save space
and can't trust compilers to get this right, fine. But that's a larger
problem, there's a a lot of strings like that. Putting each one in its
own .o file is _not_ a good solution here.
We need to work out some kind of mechanism for this, but having an
individual .c file and individual .o file for each string is just... Ick.
Rob
More information about the busybox
mailing list