[PATCH] dont compile pwd_to_spwd when shadow passwds is off

Rob Landley rob at landley.net
Sat Sep 17 06:21:44 UTC 2005


On Friday 16 September 2005 15:05, Amir Shalem wrote:
> pwd2spwd is enabled only when CONFIG_FEATURE_SHADOWPASSWDS

Understood, and I see the reason for the #ifdef now.  (The return type of the 
function is only defined when that header file is there.)  However:

> you can either choose the patch attached below,
> or use the orignal patch i have sent.
>
> pwd2spwd is not a <shadow.h> function
> and should be enabled even if !CONFIG_USE_BB_SHADOW.

Yet it needs shadow.h in order to define its return type, so if shadow.h isn't 
there (as in uclibc with that option switched off), then pwd2spwd.c won't 
compile, correct?

Are you saying that enabling CONFIG_USE_BB_SHADOW still requires shadow 
password support in uClibc in order to compile?  If so, what's the point of 
that option even existing?

Rob



More information about the busybox mailing list