[PATCH] size reduction and clean up swaponoff.c

[Mike Frysinger]

On Friday 16 September 2005 01:32 am, Rob Landley wrote:
> The patch you attached wasn't the "multiple paths" issue, but the "suppress
> error" issue.

thats because i committed the 'multiple paths' fix to svn

> (And the patch gets it wrong: only the "already on" or 
> "already off" errors are suppressed.  Something like file not found is not
> suppressed (by swapon, at least).)  Play with the util-linux version a
> bit...

i did play with it, `swapon -a` and `swapoff -a` from util-linux will error if 
fstab lists a path which doesnt exist ... the -a option doesnt suppress all 
errors, just the ones that make sense to supress

> Now admittedly we could skip both in the name of size.  What we might want
> to do is have a CONFIG option to enable these two extra features for people
> who want to replace util-linux with busybox in a real system.  (Like me. :)

that'd work for me too

> > we're talking a rough range of 30-40 additional bytes on an amd64 host
> > ... it isnt a feature i would require in busybox considering it's merely
> > cosmetic one, but i would require in the 'full' featured one from
> > util-linux
>
> I want busybox to be able to replace the gnu tools.  (Doesn't mean we have
> to implement everything they do, but in this case it seems to me we're not
> up to spec.)
>
> Speaking of which, is there a spec for this?  It's not in susv3.  Best I
> can find seems to be the man page...

no idea
-mike