svn commit: trunk/busybox: coreutils coreutils/libcoreutils include etc...

[Rob Landley]

On Monday 12 September 2005 01:17, Manuel Novoa III wrote:
> Hi Rob,
>
> Just got back...

> > I changed the variable names (and whitespace) as a separate checkin.  The
> > variable names weren't english and didn't describe what the variables
> > were used for.  They might as well have been register names.
>
> s = start... e = end.  If it's my code and I'm supporting it, it makes
> it easier for me to have it in my coding style with my conventions.

Understood, but could you at least spell out "start" and "end"?

(P.S.  I don't get it: end isn't the end of the string, it's the start of the 
portion of the string after any skipped fields...?)

> As I wrote you the other day, your changes were same size or larger for
> the two platforms I tested.  What compiler are you using and for what arch?

gcc 3.3.5 on x86.

> Rest assured that I'm not going to revert something that it measurably
> smaller unless it is broken or adds bugs.  Remember that I use busybox
> too and I'm definitely all for code as small as possible.

I try to increase simplicity and maintainability when it doesn't cost size, 
and when we do have something obscure in the name of size I really like 
commenting it.  (For example, it wasn't immediately clear to me what the 
bytes at the end of the option string were for.  And when I figured it out, I 
commented it...)

> Manuel

Rob