console-tools size optimization

[Tito]

On Thursday 08 September 2005 05:28, you wrote:
> On Wednesday 07 September 2005 09:42, Tito wrote:
> > Hi,
> > this is a series of patches to reduce the size of some console-tools
> > applets:
> 
> chvt yay.
> 
> deallocvt: you're sure -1 is the only error code ever returned?
From man ioctl:
RETURN VALUE
       Usually, on success zero is returned.  A  few  ioctls  use  the  return
       value as an output parameter and return a nonnegative value on success.
       On error, -1 is returned, and errno is set appropriately.
Ciao,
Tito
> setconsole: yay, and is this already using one instance of those strings?  
> (When we introduce a string table to ease translation, should non-translated 
> strings be merged on general principles, or what?)
> 
> One advantage of a string table is that by putting lots of strings together, 
> it's easier to see similar ones that can be re-used in different areas...
> 
> openvt: yay.
> 
> Applied (r11390), but I'd appreciate an answer to the deallocvt question.  
> (And no, I don't know why it saves size either.  I suspect on other platforms 
> it might not, and consider it by far the weakest patch of the lot...)
> 
> Rob
> 
>