svn commit: trunk/busybox: coreutils coreutils/libcoreutils include etc...

[Rob Landley]

On Wednesday 07 September 2005 20:38, Manuel Novoa III wrote:
> Rob,
>
> On Tue, Sep 06, 2005 at 09:18:38PM -0700, landley at busybox.net wrote:
> > Author: landley
> > Date: 2005-09-06 21:18:36 -0700 (Tue, 06 Sep 2005)
> > New Revision: 11347
> >
> > Log:
> > Don't comment warnings.  Don't put #warnings about warnings.  _FIX_
> > warnings.
>
> It was a meaningless warning and did not need 'fixing'.  Get a grip...

Sorry, I'm trying to get all the warnings out.

> > This fixes the warning, and makes the binary smaller out of sheer pique.
> > (Yes, since Manuel did this one it's nice tight code that took several
> > attempts to shrink, but I was ticked.)
>
> Ticked about what?

It was mostly that a #warning that got checked into the bunzip2 code that got 
to me.  (Not actually my code, but the wrapper that calls it, anyway.)  
That's what made me decide to try to remove all the warnings in busybox...

> Last time I checked, I wasn't trying to impose my 
> coding style on your code. 

Not saying you were.

> And by the way, for two arches I checked, 
> the size of my code was either the same or a byte smaller.

As I said, nice tight code that's really hard to shrink.

But moving the assignments from the end of the loop to the beginning did 
indeed make the warnings go away.  Yeah, in part it's because our compiler is 
stupid, but once you get up to a dozen or so warnings real bugs start getting 
lost in the shuffle.  Easiest to just not to have any...

> Manuel

Rob