httpd translates %xx and generates a false QUERY_STRING for cgi scripts.

Bernhard Fischer rep.nop at aon.at
Mon Sep 5 10:04:07 UTC 2005


On Mon, Sep 05, 2005 at 12:13:07PM +0400, Vladimir N. Oleynik wrote:
>Rob,
>
>>I could I get a second opinion from somebody who's played with this before 
>>I apply it?
>
>I have write access to SVN now.
>Give with you we shall agree, that you will not bring hasty corrections
>to my supported applets?
>
>My TODO for httpd:
>
>1) support all apache-like environs
>2) SSI support

apropos httpd..

What's the deal with MAXPATHLEN?

If i try to avoid pulling in linux/autoconf.h (which defines
CONFIG_SYSCTL) from busybox.h, i end with MAXPATHLEN undefined in a few
applets (httpd is umong them).
Current svn, which includes sys/param.h unconditionally, fails on a
fresh checkout in applets.[ch] because autoconf.h defines CONFIG_SYSCTL.
To reproduce, try:
svn co busybox;make defconfig;make

I thought about doing this in busybox.h to procrastinate cleaning up the
config-namespace mess a bit:
@@ -113,7 +113,9 @@ extern const struct BB_applet applets[];
 #include <limits.h>

 /* for PATH_MAX on systems that don't have it in limits.h */
+#ifndef PATH_MAX
 #include <sys/param.h>
+#endif
 #ifndef PATH_MAX
 #define  PATH_MAX         256
 #endif

and use pathconf("/",PATH_MAX); to set MAXPATHLEN. But i'm not sure if
this is a good idea.

What do you think?
thank you,
Bernhard



More information about the busybox mailing list