[patch] proposed change to busybox option parsing.

Vladimir N. Oleynik dzo at simtreas.ru
Mon Sep 5 08:15:40 UTC 2005


Rob,

> -	return (main(argc, argv));
> +	/* I can put this back, but why are we doing it again? */
> +	
> +//	/* Move the command line down a notch */
> +//	/* Preserve pointers so setproctitle() works consistently */
> +//	len = argv[argc] + strlen(argv[argc]) - argv[1];
> +//	memmove(argv[0], argv[1], len);
> +//	memset(argv[0] + len, 0, argv[1] - argv[0]);
> +//
> +//	/* Fix up the argv pointers */
> +//	len = argv[1] - argv[0];
> +//	memmove(argv, argv + 1, sizeof(char *) * (argc + 1));
> +//	for (i = 0; i < argc; i++)
> +//		argv[i] -= len;
>  }

O my God!
This code is a lot of years as is proved!
Well what for you alter not consulting with anybody?


--w
vodz



More information about the busybox mailing list