tar bugfix patch n.347 (recoded, version 5)

Roberto A. Foglietta me at roberto.foglietta.name
Fri Dec 23 13:08:08 UTC 2005


Rob Landley ha scritto:

  [cut]

> 
>>  Applaying patch n.4 and restoring original open_transform.c works too:
> 
> 
> Use of open_transform.c here is something I need to fix.  (have you seen my 
> personal todo list?)
> 
> http://www.landley.net/code/todo.txt
> 

  You seem a little bit busy.
  So I have to say two times thanks for vfork/atexit lesson
  :-)



> 
>>  So at least under the point of view of storage patch n.4 do not add
>>anything... Unbelivable... I do *NOTHING*
>>  ;-)
> 
> 
> http://www.busybox.net/FAQ.html#optimize
> 

  I seen now but...

[roberto at wsraf busybox-1.01_raf]$ make sizes
make: *** No rule to make target `sizes'.  Stop.


  In any case, patch n.4 adds up 368 bytes:

[roberto at wsraf busybox-1.01]$ size busybox
    text    data     bss     dec     hex filename
  231289    2292   36696  270277   41fc5 busybox

[roberto at wsraf busybox-1.01_raf]$ size busybox
    text    data     bss     dec     hex filename
  231657    2292   36696  270645   42135 busybox


the problem of returns stay in this code archival/gunzip.c

         if ((status != EXIT_SUCCESS) && (new_path)) {
             /* Unzip failed, remove new path instead of old path */
             delete_path = new_path;
         }


but patch n.5 developed as you indicated instead adds up 304 bytes:

[roberto at wsraf busybox-1.01_raf_5]$ size busybox
    text    data     bss     dec     hex filename
  231593    2292   36696  270581   420f5 busybox

I did not test it extensively yet, because I am waiting your response.
If it is good for you I will test it before adding in in bug-system.


> 
>>  emh.. why a such thing could happen? Two different branch of the same
>>binary which has the *exactly* same file size and different behaviure?
> 
> 
> How big are the two different busybox base applets with tar not compiled in?  
> I think we shrank the base busybox applet slightly.
> 

  default config without tar

[roberto at wsraf busybox-1.01]$ size busybox
    text    data     bss     dec     hex filename
  224725    2292   36696  263713   40621 busybox

[roberto at wsraf busybox-1.01_raf_5]$ size busybox
    text    data     bss     dec     hex filename
  224725    2292   36696  263713   40621 busybox


  default config without any archival applets

[roberto at wsraf busybox-1.01]$ size busybox
    text    data     bss     dec     hex filename
  205498    2196   26328  234022   39226 busybox

[roberto at wsraf busybox-1.01_raf_5]$ size busybox
    text    data     bss     dec     hex filename
  205498    2196   26328  234022   39226 busybox


  default config with all archival applets, the patch add 288 bytes

[roberto at wsraf busybox-1.01]$ size busybox
    text    data     bss     dec     hex filename
  254051    2396  967736 1224183  12adf7 busybox

[roberto at wsraf busybox-1.01_raf_5]$ size busybox
    text    data     bss     dec     hex filename
  254339    2396  967736 1224471  12af17 busybox






  Cheers,
-- 
Roberto A. Foglietta
http://www.roberto.foglietta.name
SkypeNick: robang74
ICQ#: 108718257

-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-1.01_raf_5.diff
Type: text/x-patch
Size: 16083 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20051223/a28956ea/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup.c
Type: text/x-csrc
Size: 227 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20051223/a28956ea/attachment.c 


More information about the busybox mailing list